-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[user_status] Improve user online status modal #38127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Let's go with real radio inputs @susnux as it's the recommended way https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/radio_role#sect1 :) |
|
@Pytal OK done (see last commit) |
3e80bc8 to
91edc9c
Compare
|
/compile |
|
Can we have before and after screenshots? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And please rebuild
2f32b69 to
25dcb9c
Compare
|
/compile |
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦭
…atus modal * Instead of tabable DIVs properly assign the radio role * Set role to radiogroup of list container to group the predefined statuses Signed-off-by: Ferdinand Thiessen <[email protected]>
…l to emoji selector Signed-off-by: Ferdinand Thiessen <[email protected]>
…ctor Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
568766c to
c588c1d
Compare
|
rebased |

Summary
radiogrouprole to online status selectorTODO
For 1: I have also created a commit where I use real radio buttons (in the background) for the predefined statuses, so the question is should I push it here too? Do we want native radio buttons instead? What do you think @Pytal @JuliaKirschenheuter ?Checklist