Skip to content

adjust wording for update hint when files of a specific app are not there #38140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 2 commits into from
May 9, 2023
Merged

adjust wording for update hint when files of a specific app are not there #38140

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e5a307
adjust wording for update hint when files of a specific app are not t…
szaimen May 9, 2023
84b88c0
adjust wording
szaimen May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
adjust wording 
Signed-off-by: Simon L <[email protected]>
  • Loading branch information
@szaimen
szaimen committed May 9, 2023
commit 84b88c01c78f7d6a6c0670d0dcf1c79664337ed7
4 changes: 2 additions & 2 deletions lib/base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,8 @@ private static function printUpgradePage(\OC\SystemConfig $systemConfig): void {

if (!empty($incompatibleShippedApps)) {
$l = Server::get(\OCP\L10N\IFactory::class)->get('core');
$hint = $l->t('The files of the app %1$s were not replaced correctly or are not existing in the first place. Make sure to add a version of the app that is compatible with the server.', [implode(', ', $incompatibleShippedApps)]);
throw new \OCP\HintException('The files of the app ' . implode(', ', $incompatibleShippedApps) . ' were not replaced correctly or are not existing in the first place. Make sure to add a version of the app that is compatible with the server.', $hint);
$hint = $l->t('Application %1$s is not present or has a non-compatible version with this server. Please check the apps directory.', [implode(', ', $incompatibleShippedApps)]);
throw new \OCP\HintException('Application ' . implode(', ', $incompatibleShippedApps) . ' is not present or has a non-compatible version with this server. Please check the apps directory.', $hint);
}

$tmpl->assign('appsToUpgrade', $appManager->getAppsNeedingUpgrade($ocVersion));
Expand Down