Skip to content

make Node::getParent lazy #38150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 5 commits into from
Sep 5, 2023
Merged

make Node::getParent lazy #38150

skjnldsv merged 5 commits into from
Sep 5, 2023

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented May 9, 2023

Since we know the parent exists and we have some basic metadata already, a lazy folder can be enough is some cases.

Main motivation is allow getting the parent it without extra db queries using $node->getParent()->getId().

skjnldsv
skjnldsv reviewed May 9, 2023
View reviewed changes
@skjnldsv skjnldsv added this to the Nextcloud 28 milestone May 9, 2023
come-nc
come-nc reviewed May 9, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems May 9, 2023
View reviewed changes
@icewind1991 icewind1991 marked this pull request as ready for review August 14, 2023 19:15
@icewind1991 icewind1991 force-pushed the lazy-folder-parent branch 5 times, most recently from fb4fc52 to c9b42f4 Compare August 15, 2023 10:12
@icewind1991
Copy link
Member Author

icewind1991 commented Aug 15, 2023 •
edited
Loading

Also made LazyFolder::getFullPath and LazyFolder::get not get the real folder if the path is known

@icewind1991 icewind1991 requested review from a team and blizzz and removed request for a team August 15, 2023 14:11
come-nc
come-nc reviewed Aug 28, 2023
View reviewed changes
@icewind1991 icewind1991 requested a review from come-nc September 4, 2023 14:53
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 5, 2023
@skjnldsv skjnldsv merged commit 7ee34a3 into master Sep 5, 2023
@skjnldsv skjnldsv deleted the lazy-folder-parent branch September 5, 2023 06:33
@artonge artonge mentioned this pull request Sep 6, 2023
Merged
2 tasks
@artonge
Copy link
Contributor

artonge commented Sep 6, 2023

There is a breaking change in the FileInfo interface, has this been reported somewhere ?

@juliusknorr juliusknorr mentioned this pull request Sep 6, 2023
Merged
4 tasks
@come-nc come-nc added the pending documentation This pull request needs an associated documentation update label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement pending documentation This pull request needs an associated documentation update performance 🚀

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991 @artonge @skjnldsv @come-nc