[stable26] Fix error on delete in ChunkingV2Plugin #38167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lorenzo Tanganelli <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return true; | ||
| } | ||
|
|
||
| [$storage, $storagePath] = $this->getUploadStorage($this->uploadPath); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
juliusknorr
approved these changes
May 15, 2023
Merged
blizzz
approved these changes
May 17, 2023
Member
|
@tanganellilore could you fix the sign-off (DCO check)? |
Contributor
|
How I can do that? In not my personal commit. |
Member
|
Could we also skip the dco check since the commit is actually already part of master with a passed dco back then? |
Member
|
On a second glance, the commit message contains the sign off. Must be a false positive in the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #38100