Skip to content

Conversation

@nickvergessen
Copy link
Member

Summary

  • Placeholder of comparison is visible glitching out of the old NcMultiselect => Migrated to NcSelect
  • X button has no title/aria label and wraps to new line
  • Add new filter option was not translated
Before After
Bildschirmfoto vom 2023-05-10 09-11-58 grafik

Checklist

@nickvergessen
Copy link
Member Author

nickvergessen commented May 10, 2023

/backport c20fd9f to stable26

@Antreesy

This comment was marked as resolved.

@nickvergessen
Copy link
Member Author

Input height is not aligned with NcSelect

Yeah can be fixed by migrating the inputs to NcTextField but I don't feel comfortable doing that skill wise (due to the v-model, etc that's necessary).

One NcMultiSelect is left there

Will have a look

@Antreesy
Copy link
Contributor

can be fixed by migrating the inputs to NcTextField

Well, NcTextField is 44px high, which is still not enough. But I could take a look afterwards

@skjnldsv skjnldsv mentioned this pull request May 10, 2023
@nickvergessen nickvergessen force-pushed the bugfix/38165/workflow-engine-ui branch from 0ff7582 to 0983572 Compare May 10, 2023 10:03
@nickvergessen
Copy link
Member Author

Fixed all the other NcMultiselect components in workflowengine

@nickvergessen nickvergessen requested a review from Antreesy May 10, 2023 10:04
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 10, 2023
@nickvergessen nickvergessen enabled auto-merge May 10, 2023 12:02
@nickvergessen nickvergessen merged commit 1085598 into master May 10, 2023
@nickvergessen nickvergessen deleted the bugfix/38165/workflow-engine-ui branch May 10, 2023 15:16
@szaimen
Copy link
Contributor

szaimen commented May 16, 2023

Thanks Joas for tackling this! As far as I can see is now only one component not migrated yet:
image

@nickvergessen
Copy link
Member Author

Cool, didn't even check that. I wanted to fix 1 component, ended up fixing a tone, and only 1 is left. That's a great outcome :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI glitch in workflowengine admin settings

5 participants