Get rid of more int casts in file size manipulations

[come-nc]

• Resolves: [Bug]: Error “Your storage is full, files can not be updated or synced anymore!" #37940

Summary

On 32bits sizes may be floats. There were a few places where this was still not taken into account.

I did not fix the following:

lib/private/Files/ObjectStore/S3.php:           return (int)$stat->get('ContentLength');
lib/private/Files/ObjectStore/ObjectStoreStorage.php:           $stat['size'] = (int)$size;

Because it would bubble up to the interface IObjectStoreMultiPartUpload in OCP, and I’m not sure if it is possible/easy to support floats there.

Also did not fix:

lib/private/Files/Stream/Encryption.php:                        $positionInFile = (int)floor($this->position / $this->unencryptedBlockSize) *
lib/private/Files/Stream/Encryption.php:                $newFilePosition = (int)floor($newPosition / $this->unencryptedBlockSize)
lib/private/Files/Stream/Encryption.php:                $position = (int)floor($this->position / $this->unencryptedBlockSize);
lib/private/Files/Stream/Encryption.php:                        $position = (int)floor($this->position / $this->unencryptedBlockSize);
lib/private/Files/Stream/Encryption.php:                        $completeBlocksInFile = (int)floor($this->unencryptedSize / $this->unencryptedBlockSize);
lib/private/Files/Stream/Encryption.php:                        if ($completeBlocksInFile === (int)floor($this->position / $this->unencryptedBlockSize)) {
lib/private/Files/Stream/Encryption.php:                        $position = (int)floor($this->position / $this->unencryptedBlockSize);
lib/private/Files/Stream/Encryption.php:                        $numberOfChunks = (int)($this->unencryptedSize / $this->unencryptedBlockSize);

It’s not clear if those can overflow or not.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

/backport to stable26

[come-nc]

/backport to stable25