Skip to content

[stable25] Fix generated avatars cache #38305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 4 commits into from
May 16, 2023
Merged

[stable25] Fix generated avatars cache #38305

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8286d2
Properly clear cached avatars
provokateurin May 9, 2023
0735020
Clear generated avatar caches
provokateurin May 9, 2023
24a50a1
adjust patch
szaimen May 16, 2023
dc3221d
adjust patch
provokateurin May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Properly clear cached avatars 
Signed-off-by: jld3103 <[email protected]>
  • Loading branch information
@provokateurin @backportbot-nextcloud
provokateurin authored and backportbot-nextcloud[bot] committed May 16, 2023
commit b8286d2ead89770e83ecf1ad232c0c9d52e2fba4
9 changes: 2 additions & 7 deletions lib/private/Avatar/AvatarManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,8 @@ public function getAvatar(string $userId) : IAvatar {
public function clearCachedAvatars() {
$users = $this->config->getUsersForUserValue('avatar', 'generated', 'true');
foreach ($users as $userId) {
try {
$folder = $this->appData->getFolder($userId);
$folder->delete();
} catch (NotFoundException $e) {
$this->logger->debug("No cache for the user $userId. Ignoring...");
}
$this->config->setUserValue($userId, 'avatar', 'generated', 'false');
// This also bumps the avatar version leading to cache invalidation in browsers
$this->getAvatar($userId)->remove();
}
}

Expand Down