[stable26] Rename numericStorageId to numericExternalStorageId in PersonalMount.php
#38317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt.php so that it doesn't override `numericStorageId` in the `MountPoint` baseclass fixes #37473 fixes #37414 Signed-off-by: Daniel <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| UserStoragesService $storagesService, | ||
| StorageConfig $storageConfig, | ||
| $storageId, | ||
| $externalStorageId, |
Check notice
Code scanning / Psalm
MissingParamType
Contributor
|
No idea what tests failed here; |
Merged
blizzz
approved these changes
May 17, 2023
blizzz
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
Member
|
failing tests are unrelated, but another review is needed |
icewind1991
approved these changes
May 17, 2023
Contributor
|
🥳 Thanks! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #38115