docs: add dbtableprefix to sample config #38321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Patil <[email protected]>
szaimen
approved these changes
May 16, 2023
nickvergessen
approved these changes
May 16, 2023
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Fine by me, but as far as I'm aware none of the installation options allow setting it anymore, so it should always be oc_
It was removed for the same reason you outlined, it can break without a prefix in certain corner cases.
Contributor
|
CI failure unrelated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately (and naturally), people copy values from the sample config and end up with databases with no prefix. This causes issues for Doctrine in certain corner cases (related pulsejet/memories#648).
So this is a simple proposal to set the sample config value to the default value.