Skip to content

[stable25] fix(search): fix load more #38325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szaimen merged 2 commits into from
May 16, 2023
Merged

[stable25] fix(search): fix load more #38325

szaimen merged 2 commits into from
May 16, 2023

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 16, 2023 •
edited by szaimen
Loading

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #38303

@skjnldsv @backportbot-nextcloud
fix(search): fix load more
075bb5f 
Signed-off-by: John Molakvoæ <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.7 milestone May 16, 2023
@szaimen
Copy link
Contributor

szaimen commented May 16, 2023

@skjnldsv we have a third window._nc_event_bus.emit('files:navigation:changed') in the app.js file here: https://github.com/nextcloud/server/blob/stable25/apps/files/js/app.js#L205. Will this break anything?

@szaimen
Copy link
Contributor

szaimen commented May 16, 2023

/compile amend /

@szaimen szaimen added the 3. to review Waiting for reviews label May 16, 2023
@szaimen szaimen marked this pull request as ready for review May 16, 2023 19:56
szaimen
szaimen approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still works

@szaimen szaimen enabled auto-merge May 16, 2023 20:04
@szaimen @nextcloud-command
fix backport
b4d7f56 
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the backport/38303/stable25 branch from f784d71 to b4d7f56 Compare May 16, 2023 20:18
@szaimen szaimen disabled auto-merge May 16, 2023 21:34
@szaimen szaimen merged commit 3f19545 into stable25 May 16, 2023
@szaimen szaimen deleted the backport/38303/stable25 branch May 16, 2023 21:34
@skjnldsv
Copy link
Member

skjnldsv commented May 17, 2023

You folks are fast! 🙈 🚀

@skjnldsv skjnldsv mentioned this pull request May 17, 2023
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: search regression

Projects

None yet

Milestone

Nextcloud 25.0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@szaimen @skjnldsv @artonge