Adjust style of passwordless login #38330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
design
Pytal
reviewed
May 17, 2023
Signed-off-by: Ferdinand Thiessen <[email protected]>
* Remove wrong background of error message boxes * Use `NcTextInput` for username or mail to align with login box * Add a heading for better overview where you (as a user) are currently Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
@Pytal thank you for your review, fixed your comments 😃 |
susnux
force-pushed
the
fix/alt-login-box-design
branch
from
05cec00 to
5be82f2
Compare
skjnldsv
approved these changes
May 17, 2023
jancborchardt
approved these changes
May 17, 2023
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Very nice @susnux, looks good design-wise! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This aligns the style of passwordless login with the current reworked login box:
NcTextInputfor username (so it now matches visually with the login box (e.g. look at the border on the screenshots))Screenshots
Checklist