Skip to content

[stable27] 38340 fix add group broken #38361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 1 commit into from
Jun 13, 2023
Merged

[stable27] 38340 fix add group broken #38361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix add new group event 
1ee8fba broke the addgroup functionality
by not updating the event to reflect the one in
https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppNavigationNewItem/NcAppNavigationNewItem.vue

Resolves : #38340

Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
@nfebe @susnux
nfebe authored and susnux committed Jun 8, 2023
commit f2e58c6c11ec9da1d2beac15176b0af7d8b8cdcf
11 changes: 5 additions & 6 deletions apps/settings/src/views/Users.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
:loading="loadingAddGroup"
:title="t('settings', 'Add group')"
@click="showAddGroupForm"
@update:title="createGroup">
@new-item="createGroup">
<template #icon>
<Plus :size="20" />
</template>
Expand Down Expand Up @@ -445,16 +445,15 @@ export default {
},

showAddGroupForm() {
this.$refs.addGroup.editingActive = true
this.$refs.addGroup.onMenuToggle(false)
this.$refs.addGroup.newItemActive = true
this.$nextTick(() => {
this.$refs.addGroup.$refs.editingInput.focusInput()
this.$refs.addGroup.$refs.newItemInput.focusInput()
})
},

hideAddGroupForm() {
this.$refs.addGroup.editingActive = false
this.$refs.addGroup.editingValue = ''
this.$refs.addGroup.newItemActive = false
this.$refs.addGroup.newItemValue = ''
},

/**
Expand Down
4 changes: 2 additions & 2 deletions dist/settings-users-8351.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-users-8351.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading