Skip to content

Adjust files favorite marker to fulfill A11Y contrast requirements #38370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Jun 6, 2023
Merged

Adjust files favorite marker to fulfill A11Y contrast requirements #38370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f57cf47
fix: Adjust color of `icon-starred-yellow` to fulfill A11Y contrast r…
susnux May 19, 2023
35da64a
fix(files): Add border around favorite marker to ensure contrast requ…
susnux May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/files/css/files.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/files/css/files.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 19 additions & 8 deletions apps/files/css/files.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,10 +585,25 @@ table td.selection {
.files-fileList tr td.filename .favorite-mark {
position: absolute;
display: block;
top: -6px;
right: -6px;
top: -8px;
right: -8px;
line-height: 100%;
text-align: center;
&.permanent {
// Create background around the favorite marker to ensure there is enough contrast
background-color: var(--color-main-background);
mask: var(--icon-star-rounded-white) no-repeat;
mask-size: 22px 22px;

width: 22px;
height: 22px;
display: flex;
align-content: center;
justify-content: center;
}
}
.files-fileList tr:hover td.filename .favorite-mark.permanent {
background-color: var(--color-background-hover);
}

#uploadsize-message,#delete-confirm { display:none; }
Expand Down Expand Up @@ -1083,10 +1098,9 @@ table.dragshadow td.size {
* Position is inherited from the selection while in grid view
*/
.favorite-mark {
padding: $grid-pad;
left: auto;
top: -22px; // center in corner of thumbnail
right: -22px; // center in corner of thumbnail
top: -11px; // center in corner of thumbnail
right: -11px; // center in corner of thumbnail
}
}
}
Expand Down Expand Up @@ -1221,10 +1235,7 @@ table.dragshadow td.size {
top: -8px; // half the checkbox width, center on corner of thumbnail
left: -8px; // half the checkbox width, center on corner of thumbnail
display: flex;
width: 44px;
height: 44px;
z-index: 10;
background: transparent;

label {
width: 44px;
Expand Down
2 changes: 1 addition & 1 deletion apps/files/css/merged.css
View file
Open in desktop

Large diffs are not rendered by default.

Loading