emit an event when a message is logged #38490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
nfebe
and removed request for
a team
1 task
icewind1991
force-pushed
the
log-dispatch-event
branch
4 times, most recently
from
3507df8 to
3d72315
Compare
icewind1991
force-pushed
the
log-dispatch-event
branch
from
3d72315 to
d246eaa
Compare
come-nc
reviewed
Jun 12, 2023
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Performance-wise, is that not too much overhead?
icewind1991
force-pushed
the
log-dispatch-event
branch
from
d246eaa to
6af1f8e
Compare
Member
Author
From my understanding the event dispatcher is well optimized for the "no listeners" case. |
come-nc
approved these changes
Jun 13, 2023
nfebe
approved these changes
Jun 13, 2023
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
log-dispatch-event
branch
from
6af1f8e to
d9fa7b1
Compare
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
This was referenced Jun 14, 2023
ChristophWurst
added
enhancement
pending documentation
Member
|
New API -> docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow apps to do their own handling, notably this is emitted even if it would be normally filtered by log level
Needed for nextcloud/logreader#873