[stable25] fix(trashbin): Truncate long filenames #38576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $trashFilename = substr_replace( | ||
| $trashFilename, | ||
| '', | ||
| $maxLength / 2, |
Check failure
Code scanning / Psalm
InvalidScalarArgument
Contributor
There was a problem hiding this comment.
Psalm error seems legit, this should be an int. How come it did not complain on original PR?
Member
There was a problem hiding this comment.
In this case maxLength is always 250 so the result is always int and can be ignored
But the alert likely didn't show initially because it exceeded the limit, see https://github.com/nextcloud/server/security/code-scanning/tools/Psalm/status/configurations/actions-FZTWS5DIOVRC653POJVWM3DPO5ZS643UMF2GSYZNMNXWIZJNMFXGC3DZONUXGLTZNVWA/ce2b36315853290650a327094ccdb926d691e375530fc54471e6d340970bbb9c
Pytal
approved these changes
Jun 1, 2023
blizzz
approved these changes
Jun 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #38355