Refactors "strpos" calls in /apps/dav #38610
Conversation
fsamapoor
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Nice!
Micro optimization: use use function str_starts_with and use function str_contains so PHP doesn't have to check if there are function with that name in the current namespace before it checks globally
Thanks for the clarification. I wasn't sure if I should keep those since there were only a couple of files that were taking advantage of this micro-optimization technique. Should I update all changed files and add use statements? |
|
It is nice to have but not a requirement |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: Thomas Citharel <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
szaimen
force-pushed
the
replace_strpos_calls_in_dav_app
branch
from
a3a6dfb to
8c64cca
Compare
szaimen
added
4. to release
Signed-off-by: Faraz Samapoor <[email protected]>
|
Does anything need to be done for this to get merged? It's been more than three months. |
4 participants
Summary
Following #38261 and #38260, I have replaced
strposcalls in/apps/davnamespace as well to improve code readability.