Skip to content

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Jun 8, 2023

Manual backport of #38398 and #38701

I kept the original migration version so it does not reflect the actual app version.

@julien-nc julien-nc added 3. to review Waiting for reviews security labels Jun 8, 2023
@julien-nc julien-nc added this to the Nextcloud 26.0.3 milestone Jun 8, 2023
@julien-nc julien-nc force-pushed the backport/38398/stable26 branch from d1eee8a to 262e9d7 Compare June 8, 2023 12:28
return null;
}

public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\OAuth2\Migration\Version011601Date20230522143227::postSchemaChange does not have a return type, expecting void
@julien-nc julien-nc force-pushed the backport/38398/stable26 branch from 262e9d7 to cb682d6 Compare June 9, 2023 08:27
@julien-nc julien-nc requested review from a team, ArtificialOwl, icewind1991, kesselb, nfebe and szaimen and removed request for a team June 9, 2023 08:27
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz mentioned this pull request Jun 12, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-nc julien-nc force-pushed the backport/38398/stable26 branch 2 times, most recently from da9a167 to 50ca447 Compare June 12, 2023 15:12
@julien-nc julien-nc requested a review from ChristophWurst June 12, 2023 15:14
@julien-nc julien-nc force-pushed the backport/38398/stable26 branch from 9e2b82c to e00f507 Compare June 14, 2023 15:30
@blizzz
Copy link
Member

blizzz commented Jun 14, 2023

What about Cypress failing?

@blizzz
Copy link
Member

blizzz commented Jun 15, 2023

moving to 26.0.4

@julien-nc julien-nc force-pushed the backport/38398/stable26 branch from e00f507 to ec284b1 Compare June 19, 2023 09:15
@julien-nc
Copy link
Member Author

julien-nc commented Jun 19, 2023

@blizzz Failing Cypress tests are related with files_versions and theming.

jsunit failure seems unrelated too:
image

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc force-pushed the backport/38398/stable26 branch from ec284b1 to 5f461bc Compare June 22, 2023 12:09
@julien-nc julien-nc merged commit 913d9da into stable26 Jun 22, 2023
@julien-nc julien-nc deleted the backport/38398/stable26 branch June 22, 2023 15:09
@blizzz blizzz mentioned this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants