Skip to content

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Jun 8, 2023

Manual backport of #38398 and #38701

I kept the original migration version so it does not reflect the actual app version.

@julien-nc julien-nc added 3. to review Waiting for reviews security labels Jun 8, 2023
@julien-nc julien-nc added this to the Nextcloud 25.0.8 milestone Jun 8, 2023
return null;
}

public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\OAuth2\Migration\Version011601Date20230522143227::postSchemaChange does not have a return type, expecting void
@julien-nc julien-nc force-pushed the backport/38398/stable25 branch 2 times, most recently from 8eedc06 to 60aa0d2 Compare June 9, 2023 08:24
@julien-nc julien-nc requested review from a team, ArtificialOwl, icewind1991, kesselb, nfebe and szaimen and removed request for a team June 9, 2023 08:25
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz mentioned this pull request Jun 12, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julien-nc julien-nc force-pushed the backport/38398/stable25 branch 2 times, most recently from 88ee6d8 to efa52d3 Compare June 12, 2023 15:13
@julien-nc julien-nc requested a review from ChristophWurst June 12, 2023 15:14
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 13, 2023
@julien-nc julien-nc force-pushed the backport/38398/stable25 branch from 83191a0 to 7f7f824 Compare June 14, 2023 15:31
@blizzz blizzz merged commit a330459 into stable25 Jun 14, 2023
@blizzz blizzz deleted the backport/38398/stable25 branch June 14, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants