Enable version features again with S3 versioning #38794
Conversation
Signed-off-by: Benjamin Somers <[email protected]>
szaimen
requested review from
a team,
artonge,
come-nc,
icewind1991 and
nfebe
and removed request for
a team
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Is support for deleting and labeling versions was added to files_versions_s3?
Yes, it has been implemented by nextcloud/files_versions_s3#27 |
|
Awesome @bensmrs. Can you fix DCO ? |
|
Hmmm I have several affiliations and the one I signed with is really the one that should appear… Any way for you to force the DCO without me having to switch my main email on GitHub (and switching it back to the current one 😓)? |
|
@bensmrs You add other email addresses in GH without messing with your primary one: |
|
It’s already the case… |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Done @bensmrs, thanks a lot for pushing this !! 🎉 |
|
/backport to stable27 |
7 participants
Summary
After nextcloud/files_versions_s3#28 is merged, we can enable version features with the S3 versioning backend again.