Fix user log.condition feature #38881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
szaimen
requested review from
a team,
blizzz,
icewind1991 and
nfebe
and removed request for
a team
Member
|
This seems to work much better... |
Contributor
Author
|
/backport to stable27 |
Contributor
Author
|
/backport to stable26 |
Contributor
Author
|
/backport to stable25 |
come-nc
force-pushed
the
fix/logcondition-user
branch
from
a014cf0 to
6b9de1a
Compare
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/logcondition-user
branch
from
6b9de1a to
8ed6086
Compare
artonge
approved these changes
Jun 26, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
User is not alway known at first log of a request, so we cannot cache log condition be request before we know the user.
Checklist