Skip to content

fix(s3): Pass SSE-C parameters for multipart upload #38934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Jul 20, 2023
Merged

fix(s3): Pass SSE-C parameters for multipart upload #38934

juliusknorr merged 1 commit into from
Jul 20, 2023

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 21, 2023 •
edited
Loading

Follow up fix for #27034 to make it work properly with SSE-C encryption enabled.

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Jun 21, 2023
@juliusknorr
Copy link
Member Author

juliusknorr commented Jun 21, 2023

/backport to stable27

@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Jun 21, 2023
@tsdicloud
Copy link
Contributor

tsdicloud commented Jul 18, 2023

This is a hot feature to combine with Verified Credentials ...

@juliusknorr juliusknorr merged commit 77f2497 into master Jul 20, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/ssec-multipart branch July 20, 2023 09:00
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 20, 2023
Merged
@ir0nhide
Copy link
Contributor

ir0nhide commented Jul 25, 2023

@juliushaertl thank you for adding SSE-C support to the new S3 MultipartUpload feature, really appreciate your work here.
After review the changes, i think you also need to add SSE-C headers to the headObject call on line 99:

server/lib/private/Files/ObjectStore/S3.php

Line 99 in f824d87

$stat = $this->getConnection()->headObject([

Reference: https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadObject.html

@ir0nhide ir0nhide mentioned this pull request Jul 30, 2023
Merged
@joshtrichards joshtrichards mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: object storage

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

6 participants

@juliusknorr @tsdicloud @ir0nhide @artonge @come-nc