[stable25] fix: BMP image without color info causes array access on false
#38959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
changed the title
falsefalse
ChristophWurst
added
3. to review
ChristophWurst
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
nfebe
approved these changes
Jun 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to access array offset on value of type bool at lib/private/legacy/OC_Image.php#934Summary
Invalid BMPs can cause PHP errors to be logged again and again.
26+ don't have this problem because the OC_Image method was replaced with a call to GD in #35560
TODO
Checklist