Skip to content

fix(dav): Catch SAB sync errors during upgrade #39005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szaimen merged 1 commit into from
Jun 27, 2023
Merged

fix(dav): Catch SAB sync errors during upgrade #39005

szaimen merged 1 commit into from
Jun 27, 2023

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 26, 2023 •
edited
Loading

Summary

Allow completion of the upgrade from 26 to 27 even if the instance runs into #38902 or #38873.

TODO

  • Improve code
  • Feedback from an affected instance

Checklist

@ChristophWurst ChristophWurst self-assigned this Jun 26, 2023
This was referenced Jun 26, 2023
Closed
Closed
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Jun 26, 2023

/backport to stable27

szaimen
szaimen approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@szaimen szaimen added this to the Nextcloud 28 milestone Jun 26, 2023
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 26, 2023
@ChristophWurst ChristophWurst marked this pull request as ready for review June 26, 2023 16:19
@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991, miaulalala and nfebe and removed request for a team June 26, 2023 16:28
@szaimen szaimen mentioned this pull request Jun 26, 2023
Closed
30 tasks
@szaimen szaimen merged commit 06c99e0 into master Jun 27, 2023
@szaimen szaimen deleted the fix/dav/upgrade-catch-sab-sync-errors branch June 27, 2023 11:01
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@szaimen szaimen szaimen approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review Waiting for reviews bug feature: carddav Related to CardDAV internals feature: dav feature: install and update

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst @miaulalala @szaimen