Add integration test for trashbin #3905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MorrisJobke
commented
Mar 17, 2017
MorrisJobke
commented
- downstream of Add integration test for trashbin owncloud/core#27069
- redo of Add integration test for trashbin #3893
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @LukasReschke and @rullzer to be potential reviewers. |
MorrisJobke
commented
Mar 17, 2017
| And user "user1" favorites element "/shared/shared_file.txt" | ||
| When User "user1" moved file "/shared/shared_file.txt" to "/taken_out.txt" | ||
| Then user "user1" in folder "/" should have favorited the following elements | ||
| | /taken_out.txt | |
Member
Author
There was a problem hiding this comment.
This tests seems to fail. The path is prefixed with /remote.php/webdav. @icewind1991 @rullzer Is this correct?
Member
There was a problem hiding this comment.
Yes that is the correct webdav path
Member
Author
There was a problem hiding this comment.
This one is forbidden. I will move this to a separate PR to maybe debug this.
Member
|
Member
Author
|
Aaah ... now it says: before prepending the 🙈 |
MorrisJobke
force-pushed
the
downstream-27069
branch
from
3f1be48 to
5779bde
Compare
Member
Author
|
Let's see if it works now |
rullzer
force-pushed
the
downstream-27069
branch
from
5779bde to
b3531f9
Compare
Member
Author
|
I will also rebase to get #4302 resolved. |
Add test for basic deletion. Add test when deleting from shared folder as recipient. Add test to check that metadata stays when moving out of shared folder as recipient. Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
downstream-27069
branch
from
b3531f9 to
749046a
Compare
Member
Author
|
👍 from me as well for this |
MorrisJobke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.