Skip to content

enh(a11y): Users table #39050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 7 commits into from
Jul 13, 2023
Merged

enh(a11y): Users table #39050

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cbfe0c6
enh(a11y): Users table
Pytal Jul 7, 2023
821fcc6
chore: Compile assets
Pytal Jul 7, 2023
957dbee
fix(cypress): users_disable
Pytal Jul 7, 2023
b65eb0c
fix(cypress): users_modify
Pytal Jul 8, 2023
ce99dd9
fix(cypress): users
Pytal Jul 8, 2023
8faa1a4
fix(acceptance): UsersSettingsContext
Pytal Jul 10, 2023
faf2b23
test(settings): Users table
Pytal Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(cypress): users_modify 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal
Pytal committed Jul 13, 2023
commit b65eb0c03d016fa86a931a1457b8a9ba464a8451
10 changes: 4 additions & 6 deletions cypress/e2e/settings/users_modify.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,23 +39,21 @@ describe('Settings: Change user properties', function() {
// open the User settings
cy.visit('/settings/users')

cy.get(`.user-list-grid .row[data-id="${jdoe.userId}"]`).within(($row) => {
cy.get(`tbody.user-list__body tr td[data-test="${jdoe.userId}"]`).parents('tr').within(() => {
// see that the list of users contains the user jdoe
cy.contains(jdoe.userId).should('exist')
// toggle the edit mode for the user jdoe
cy.get('.userActions .action-items > button:first-of-type').click()
cy.get('td.row__cell--actions .action-items > button:first-of-type').click()
})

cy.get(`.user-list-grid .row[data-id="${jdoe.userId}"]`).within(($row) => {
// see that the edit mode is on
cy.wrap($row).should('have.class', 'row--editable')
cy.get(`tbody.user-list__body tr td[data-test="${jdoe.userId}"]`).parents('tr').within(() => {
// see that the password of user0 is ""
cy.get('input[type="password"]').should('exist').and('have.value', '')
// set the password for user0 to 123456
cy.get('input[type="password"]').type('123456')
// When I set the password for user0 to 123456
cy.get('input[type="password"]').should('have.value', '123456')
cy.get('.password button').click()
cy.get('input[type="password"] ~ button').click()

// Ignore failure if modal is not shown
cy.once('fail', (error) => {
Expand Down