Skip to content

fix(TagSearchProvider): Short circuit if no tag matches the query #39062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 2 commits into from
Jul 5, 2023
Merged

fix(TagSearchProvider): Short circuit if no tag matches the query #39062

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2951ae2
fix(TagSearchProvider): Short circuit if no tag matches the query
marcelklehr Jun 29, 2023
29c0e07
Fix psalm error
marcelklehr Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix psalm error 
Signed-off-by: Marcel Klehr <[email protected]>
  • Loading branch information
@marcelklehr
marcelklehr committed Jun 30, 2023
commit 29c0e078a1ed22644d1a0b31ec5693be100e38ad
2 changes: 1 addition & 1 deletion apps/systemtags/lib/Search/TagSearchProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public function getOrder(string $route, array $routeParameters): int {
* @inheritDoc
*/
public function search(IUser $user, ISearchQuery $query): SearchResult {
$matchingTags = $this->tagManager->getAllTags(1, $query->getTerm());
$matchingTags = $this->tagManager->getAllTags(true, $query->getTerm());
if (count($matchingTags) === 0) {
return SearchResult::complete($this->l10n->t('Tags'), []);
}
Expand Down