Skip to content

Silent imagecreatefromstring() errors #39093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
solracsf merged 1 commit into from
Jul 1, 2023
Merged

Silent imagecreatefromstring() errors #39093

solracsf merged 1 commit into from
Jul 1, 2023

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jun 30, 2023 •
edited
Loading

Summary

There isn't much we can do about, and all other calls to this same function on the same file are already silent.

Error: imagecreatefromstring(): Data is not in a recognized format at /lib/private/legacy/OC_Image.php#758

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Jun 30, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jun 30, 2023
@kesselb
Copy link
Contributor

kesselb commented Jun 30, 2023

Thanks for your pr 👍

I thought you didn't like the silent operator? 😃

@kesselb kesselb requested review from nfebe and szaimen June 30, 2023 21:42
@kesselb kesselb added the bug label Jun 30, 2023
@solracsf
Copy link
Member Author

solracsf commented Jun 30, 2023 •
edited
Loading

I thought you didn't like the silent operator?

I can make an effort for previews 😝

@nfebe
Copy link
Contributor

nfebe commented Jun 30, 2023

I thought you didn't like the silent operator? 😃

Add me to the list.

@solracsf
Copy link
Member Author

solracsf commented Jul 1, 2023

/backport to stable27

@solracsf
Copy link
Member Author

solracsf commented Jul 1, 2023

/backport to stable26

@solracsf
Copy link
Member Author

solracsf commented Jul 1, 2023

/backport to stable25

@solracsf solracsf merged commit 914cb80 into master Jul 1, 2023
@solracsf solracsf deleted the imageCreateFromString branch July 1, 2023 14:34
This was referenced Jul 1, 2023
Merged
Merged
Merged
@joshtrichards
Copy link
Member

joshtrichards commented Jul 1, 2023

Possibly fixes (at least partially): #36244 and possibly exacerbates or hides (or fixes? hah) whatever #37044 is.

This was referenced Jul 2, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

@nfebe nfebe nfebe approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

5 participants

@solracsf @kesselb @nfebe @joshtrichards