[1/2] Refactors lib/private/Collaboration #39113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
nfebe
reviewed
Jul 13, 2023
nfebe
reviewed
Jul 13, 2023
nfebe
reviewed
Jul 13, 2023
nfebe
reviewed
Jul 13, 2023
nfebe
reviewed
Jul 13, 2023
nfebe
reviewed
Jul 13, 2023
nfebe
reviewed
Jul 13, 2023
nfebe
reviewed
Jul 13, 2023
nfebe
requested changes
Jul 13, 2023
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Few inline comments mostly type hinting
Member
Author
|
@fenn-cs Thank you for taking the time to review the changes. Almost all of the comments boil down to the inability of adding the parameter type hints, because of the implemented interfaces. I don't think this is the right time and PR to do such changes in all the interfaces and as a result, all the implemented classes. |
fsamapoor
force-pushed
the
refactor_lib_private_collaboration_part1
branch
2 times, most recently
from
c36f15e to
c60f54b
Compare
nfebe
approved these changes
Jul 14, 2023
artonge
approved these changes
Sep 21, 2023
artonge
force-pushed
the
refactor_lib_private_collaboration_part1
branch
from
c60f54b to
48c92a4
Compare
Mainly using PHP8's constructor property promotion. Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: fenn-cs <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
fsamapoor
force-pushed
the
refactor_lib_private_collaboration_part1
branch
from
48c92a4 to
14ad1e9
Compare
Member
Author
|
@artonge Thank you for the review. Rebased it again to pass the failed DCO workflow. |
icewind1991
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following previous PRs taking advantage of PHP8's constructor property promotion in
/core/namespace, I have also made the required adjustments to the classes in/lib/private/Collaborationnamespace.I figured I should split the changes into two PRs to make reviewing the changes easier.
The improvements in this PR include but are not limited to:
Checklist