Skip to content

fix(sse): don't update uncached files #39115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 1 commit into from
Jul 4, 2023
Merged

fix(sse): don't update uncached files #39115

blizzz merged 1 commit into from
Jul 4, 2023

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Jul 3, 2023 •
edited
Loading

  • Resolves: (not yet reported)

Summary

Certain files (e.g. *.part) are not cached in the file cache and thus have no fileid. However, the encryption storage wrapper tries to update their cache entries regardless which will fail as $info->getId() throws an exception ("Undefined array key \"fileid\").

Checklist

@st3iny st3iny self-assigned this Jul 3, 2023
@st3iny st3iny marked this pull request as draft July 3, 2023 07:48
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 3, 2023
View reviewed changes
icewind1991
icewind1991 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@st3iny
fix(sse): don't update uncached files
c4eccbb 
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny force-pushed the fix/unecrypted-size-part-files branch from f84dda4 to c4eccbb Compare July 4, 2023 10:42
@st3iny
Copy link
Member Author

st3iny commented Jul 4, 2023

/backport to stable27

@st3iny
Copy link
Member Author

st3iny commented Jul 4, 2023

/backport to stable26

@st3iny
Copy link
Member Author

st3iny commented Jul 4, 2023

/backport to stable25

@st3iny st3iny marked this pull request as ready for review July 4, 2023 10:43
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 4, 2023
@st3iny st3iny requested a review from come-nc July 4, 2023 10:43
@st3iny st3iny added this to the Nextcloud 28 milestone Jul 4, 2023
@st3iny st3iny requested review from a team, ArtificialOwl and blizzz and removed request for a team July 4, 2023 13:54
@blizzz blizzz merged commit bacd14a into master Jul 4, 2023
@blizzz blizzz deleted the fix/unecrypted-size-part-files branch July 4, 2023 20:12
This was referenced Jul 4, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@blizzz blizzz blizzz approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

Assignees

@st3iny st3iny

Labels

3. to review Waiting for reviews bug feature: encryption (server-side)

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@st3iny @icewind1991 @blizzz