Skip to content

Refactor lib/private/Remote #39163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shdehnavi wants to merge 13 commits into from
Closed

Refactor lib/private/Remote #39163

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7387ace
use PHP8's match expression instead of switch
shdehnavi Jul 5, 2023
c3948dd
use PHP8's constructor property promotion
shdehnavi Jul 5, 2023
eb60605
add return and throws types and types to properties
shdehnavi Jul 5, 2023
fdac308
Make adjustments based on the review
shdehnavi Jul 6, 2023
a1c78f5
Make adjustments based on the review
shdehnavi Jul 14, 2023
62e90d1
Make adjustments based on the psalm messages
shdehnavi Jul 16, 2023
4c8049f
Update lib/private/Remote/Credentials.php
shdehnavi Jul 17, 2023
4bcbeff
Update lib/private/Remote/Credentials.php
shdehnavi Jul 17, 2023
99afc89
Update lib/private/Remote/Credentials.php
shdehnavi Jul 17, 2023
f9ba9a8
Update lib/private/Remote/Instance.php
shdehnavi Jul 17, 2023
b0e30b7
Update lib/private/Remote/User.php
shdehnavi Jul 17, 2023
bddeceb
Update lib/private/Remote/User.php
shdehnavi Jul 18, 2023
aca7255
Make adjustments based on the review
shdehnavi Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make adjustments based on the review 
Signed-off-by: Hamid Dehnavi <[email protected]>
  • Loading branch information
@shdehnavi
shdehnavi committed Jul 24, 2023
commit aca7255dc53fb649fc6e1dcad56d6f3a40c61ea9
4 changes: 2 additions & 2 deletions lib/private/Remote/Instance.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ public function getVersion(): ?string {
}

/**
* @return string 'http' or 'https'
* @return string|null 'http' or 'https'

Check failure

Code scanning / Psalm

ImplementedReturnTypeMismatch

The inherited return type 'string' for OCP\Remote\IInstance::getProtocol is different to the implemented return type for OC\Remote\Instance::getprotocol 'null|string'
* @throws NotFoundException
*/
public function getProtocol(): string {
public function getProtocol(): ?string {
$status = $this->getStatus();
return $status['protocol'];
}
Expand Down