Skip to content

refactor core/Middleware #39176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shdehnavi wants to merge 3 commits into from
Closed

refactor core/Middleware #39176

shdehnavi wants to merge 3 commits into from

Conversation

@shdehnavi
Copy link
Contributor

@shdehnavi shdehnavi commented Jul 5, 2023

Summary

The required adjustments have been made to the classes in the /core/Middleware namespace.

The improvements:

  • Adding return types
  • Adding throws types
  • Adding types to properties

Checklist

@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 6, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 6, 2023
@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
come-nc
come-nc requested changes Jul 18, 2023
View reviewed changes
@shdehnavi shdehnavi requested a review from come-nc July 18, 2023 08:42
shdehnavi and others added 3 commits September 29, 2023 11:35
@shdehnavi @fsamapoor
refactor core/Middleware
6bf68ab 
Signed-off-by: Hamid Dehnavi <[email protected]>
@shdehnavi @come-nc @fsamapoor
Update core/Middleware/TwoFactorMiddleware.php
1efe84d 
Co-authored-by: Côme Chilliet <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
@shdehnavi @come-nc @fsamapoor
Update core/Middleware/TwoFactorMiddleware.php
c54570b 
Co-authored-by: Côme Chilliet <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
@fsamapoor fsamapoor force-pushed the refactor_core_middleware branch from 487ebc4 to c54570b Compare September 29, 2023 08:05
@come-nc
Copy link
Contributor

come-nc commented Oct 2, 2023

Error: core/Middleware/TwoFactorMiddleware.php:73:7: TypeDoesNotContainType: Cannot resolve types for $controller - OCP\AppFramework\Controller does not contain OCA\TwoFactorNextcloudNotification\Controller\APIController (see https://psalm.dev/056)

@shdehnavi shdehnavi closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fsamapoor fsamapoor fsamapoor approved these changes

@come-nc come-nc come-nc approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@shdehnavi @come-nc @fsamapoor @solracsf