Skip to content

Refactor core/BackgroundJobs #39182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Feb 26, 2024
Merged

Refactor core/BackgroundJobs #39182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47361fd
Refactor core/BackgroundJobs
shdehnavi Jul 6, 2023
246218d
Make adjustments based on the review
shdehnavi Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/BackgroundJobs/BackgroundCleanupUpdaterBackupsJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,10 @@ public function __construct(

/**
* This job cleans up all backups except the latest 3 from the updaters backup directory
*
* @param array $argument
*/
public function run($arguments) {
public function run($argument): void {
$updateDir = $this->config->getSystemValue('updatedirectory', null) ?? $this->config->getSystemValue('datadirectory', \OC::$SERVERROOT . '/data');
$instanceId = $this->config->getSystemValue('instanceid', null);

Expand Down
5 changes: 4 additions & 1 deletion core/BackgroundJobs/LookupServerSendCheckBackgroundJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ public function __construct(
parent::__construct($time);
}

public function run($arguments) {
/**
* @param array $argument
*/
public function run($argument): void {
$this->userManager->callForSeenUsers(function (IUser $user) {
$this->config->setUserValue($user->getUID(), 'lookup_server_connector', 'dataSend', '1');
});
Expand Down