Refactor core/Command/Background #39184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Jul 7, 2023
ChristophWurst
approved these changes
Jul 7, 2023
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Squash your commits into one please
👍 thanks
Merged
Signed-off-by: Hamid Dehnavi <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]> Co-authored-by: Christoph Wurst <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]> Co-authored-by: Christoph Wurst <[email protected]>
skjnldsv
force-pushed
the
refactor_core_command_background
branch
from
607f75e to
7062314
Compare
skjnldsv
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The required adjustments have been made to the classes in
/core/Command/Backgroundnamespace.The improvements:
Checklist