Skip to content

Refactor admin audit app #39192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danialRahimy wants to merge 9 commits into from
Closed

Refactor admin audit app #39192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7974ab4
Revert condition to iterate early in the loop
danialRahimy Jul 6, 2023
202906a
Extract codes to separate methods to more readability
danialRahimy Jul 6, 2023
e17c223
Replace conditions with match expression according to php8
danialRahimy Jul 6, 2023
9a51a0d
Declare methods return types
danialRahimy Jul 6, 2023
b06913d
Add properties type
danialRahimy Jul 6, 2023
47e4add
Run php-cs-fixer
danialRahimy Jul 6, 2023
009983e
Remove property type to fix psalm error
danialRahimy Aug 16, 2023
b01dd7c
Update apps/admin_audit/lib/AuditLogger.php
danialRahimy Aug 17, 2023
5db849f
Updated array usage from array() to [] for improved code readability …
danialRahimy Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions apps/admin_audit/lib/Actions/Action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@
use OCA\AdminAudit\IAuditLogger;

class Action {

public function __construct(
private IAuditLogger $logger,
) {}
) {
}

/**
* Log a single action with a log level of info
Expand All @@ -49,23 +49,26 @@ public function log(string $text,
array $elements,
bool $obfuscateParameters = false): void {
foreach ($elements as $element) {
if (!isset($params[$element])) {
if ($obfuscateParameters) {
$this->logger->critical(
'$params["'.$element.'"] was missing.',
['app' => 'admin_audit']
);
} else {
$this->logger->critical(
sprintf(
'$params["'.$element.'"] was missing. Transferred value: %s',
print_r($params, true)
),
['app' => 'admin_audit']
);
}
return;
if (isset($params[$element])) {
continue;
}

if ($obfuscateParameters) {
$this->logger->critical(
'$params["'.$element.'"] was missing.',
['app' => 'admin_audit']
);
} else {
$this->logger->critical(
sprintf(
'$params["'.$element.'"] was missing. Transferred value: %s',
print_r($params, true)
),
['app' => 'admin_audit']
);
}

return;
}

$replaceArray = [];
Expand Down
1 change: 0 additions & 1 deletion apps/admin_audit/lib/Actions/AppManagement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
namespace OCA\AdminAudit\Actions;

class AppManagement extends Action {

/**
* @param string $appName
*/
Expand Down
1 change: 0 additions & 1 deletion apps/admin_audit/lib/Actions/GroupManagement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
* @package OCA\AdminAudit\Actions
*/
class GroupManagement extends Action {

/**
* log add user to group event
*
Expand Down
Loading