Skip to content

[stable27] use more efficient tag retrieval on DAV report request #39202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 14 commits into from
Jul 7, 2023
Merged

[stable27] use more efficient tag retrieval on DAV report request #39202

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7bfe6f2
use efficient tag retrieval on DAV report request
blizzz Apr 28, 2023
7d8d586
fix: change if with conditionless else to switch; and a parameter value
blizzz May 11, 2023
99442b6
fix: favorites view and universal search against tags
blizzz May 11, 2023
36a0d14
fix: ensure searchBySystemTag() is available
blizzz May 11, 2023
f872867
chore: cleanup unused code
blizzz May 11, 2023
4e5c3bd
fix: no search when LazyFolder was provided
blizzz May 12, 2023
4ac77f0
fix: search with more than one search tags
blizzz Jun 2, 2023
66a7064
fix: include invisible tags for admins
blizzz Jun 15, 2023
b55be6f
fix: cominbation of small fixes
blizzz Jun 21, 2023
a5a1345
fix: obey offset and limit for results from favs and circles
blizzz Jun 21, 2023
653812d
fix: use array_unitersect against objects
blizzz Jun 21, 2023
d05d185
refactor: save unnecessary method_exists
blizzz Jun 21, 2023
35de0b5
fix: cannot apply limit+offset on multi-tag-search
blizzz Jun 27, 2023
a7b4f50
refactor: adjust to unexposed searchBySystemTag
blizzz Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: ensure searchBySystemTag() is available 
Signed-off-by: Arthur Schiwon <[email protected]>
  • Loading branch information
@blizzz @backportbot-nextcloud
blizzz authored and backportbot-nextcloud[bot] committed Jul 6, 2023
commit 36a0d1486e57db13c8f7b9fc094b30dbf430bc77
4 changes: 3 additions & 1 deletion apps/dav/lib/Connector/Sabre/FilesReportPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,9 @@ protected function processFilterRulesForFileNodes(array $filterRules, ?int $limi

$nodes = [];

if (!empty($systemTagIds)) {
// type check to ensure searchBySystemTag is available, it is not
// exposed in API yet
if (!empty($systemTagIds) && $this->userFolder instanceof \OC\Files\Node\Folder) {
$tags = $this->tagManager->getTagsByIds($systemTagIds);
$tagName = (current($tags))->getName();
$nodes = $this->userFolder->searchBySystemTag($tagName, $this->userSession->getUser()->getUID(), $limit ?? 0, $offset ?? 0);
Expand Down