Skip to content

Refactor core/Controller #39212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shdehnavi wants to merge 17 commits into from
Closed

Refactor core/Controller #39212

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f48db5a
Refactor core/Controller
shdehnavi Jul 7, 2023
51040b1
Update core/Controller/GuestAvatarController.php
shdehnavi Jul 14, 2023
be9e908
Make adjustments based on the review
shdehnavi Jul 14, 2023
7e4ca27
Make adjustments based on the review
shdehnavi Jul 14, 2023
dbda422
Make adjustments based on the review
shdehnavi Jul 14, 2023
8913eb8
Update core/Controller/ClientFlowLoginController.php
shdehnavi Jul 19, 2023
f24dc3f
Update core/Controller/CssController.php
shdehnavi Jul 19, 2023
bc5dbd2
Update core/Controller/ContactsMenuController.php
shdehnavi Jul 19, 2023
1c942b4
Update core/Controller/JsController.php
shdehnavi Jul 19, 2023
2302df8
Update core/Controller/LoginController.php
shdehnavi Jul 19, 2023
ee576ef
Update core/Controller/TwoFactorChallengeController.php
shdehnavi Jul 19, 2023
b169a24
Update core/Controller/TwoFactorChallengeController.php
shdehnavi Jul 19, 2023
f2b03d1
Update core/Controller/TwoFactorChallengeController.php
shdehnavi Jul 19, 2023
cd4bbc5
Update core/Controller/WellKnownController.php
shdehnavi Jul 19, 2023
c54a665
Update core/Controller/TwoFactorChallengeController.php
shdehnavi Jul 19, 2023
dde0ef7
Make adjustments based on the review
shdehnavi Jul 19, 2023
78a0f52
Make adjustments based on the review
shdehnavi Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make adjustments based on the review 
Signed-off-by: Hamid Dehnavi <[email protected]>
  • Loading branch information
@shdehnavi
shdehnavi committed Jul 24, 2023
commit 78a0f522374d74bb51389306ecd9c093c475495f
1 change: 0 additions & 1 deletion core/Controller/LoginController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
use OCP\AppFramework\Http\Attribute\UseSession;
use OCP\AppFramework\Http\DataResponse;
use OCP\AppFramework\Http\RedirectResponse;
use OCP\AppFramework\Http\Response;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\Defaults;
use OCP\IConfig;
Expand Down
21 changes: 0 additions & 21 deletions core/Controller/PreviewController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,6 @@ public function getPreview(
/**
* @NoAdminRequired
* @NoCSRFRequired
*
* @param int $fileId
* @param int $x
* @param int $y
* @param bool $a
* @param bool $forceIcon
* @param string $mode
* @return DataResponse|FileDisplayResponse
* @throws NoUserException
* @throws NotPermittedException
*/
public function getPreviewByFileId(
int $fileId = -1,
Expand All @@ -120,17 +110,6 @@ public function getPreviewByFileId(
return $this->fetchPreview($node, $x, $y, $a, $forceIcon, $mode);
}

/**
* @param Node $node
* @param int $x
* @param int $y
* @param bool $a
* @param bool $forceIcon
* @param string $mode
* @return Response
* @throws NotFoundException
* @throws InvalidPathException
*/
private function fetchPreview(
Node $node,
int $x,
Expand Down
8 changes: 0 additions & 8 deletions core/Controller/ProfileApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,6 @@ public function __construct(
* @NoSubAdminRequired
* @PasswordConfirmationRequired
* @UserRateThrottle(limit=40, period=600)
* @param string $targetUserId
* @param string $paramId
* @param string $visibility
* @return DataResponse
* @throws OCSBadRequestException
* @throws OCSForbiddenException
* @throws OCSNotFoundException
* @throws Exception
*/
public function setVisibility(string $targetUserId, string $paramId, string $visibility): DataResponse {
$requestingUser = $this->userSession->getUser();
Expand Down
2 changes: 1 addition & 1 deletion core/Controller/TwoFactorChallengeController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ public function showChallenge(string $challengeProviderId, string $redirect_url)
* @return RedirectResponse
*/
#[UseSession]
public function solveChallenge(string $challengeProviderId, string $challenge, string $redirect_url = null): RedirectResponse {
public function solveChallenge(string $challengeProviderId, string $challenge, ?string $redirect_url = null): RedirectResponse {
$user = $this->userSession->getUser();
$provider = $this->twoFactorManager->getProvider($user, $challengeProviderId);
if (is_null($provider)) {
Expand Down