Skip to content

Refactor comments app #39236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Sep 28, 2023
Merged

Refactor comments app #39236

skjnldsv merged 2 commits into from
Sep 28, 2023

Conversation

@shdehnavi
Copy link
Contributor

@shdehnavi shdehnavi commented Jul 7, 2023

Summary

The required adjustments have been made to the comments app.

The improvements:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Adding types to properties
  • Updating doc blocks
  • Converting isset ternary to null coalescing operator

Checklist

@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
nickvergessen
nickvergessen requested changes Jul 17, 2023
View reviewed changes
@shdehnavi shdehnavi requested a review from nickvergessen July 17, 2023 15:38
shdehnavi and others added 2 commits September 28, 2023 09:16
@shdehnavi @fsamapoor
Refactor comments app
8782880 
Signed-off-by: Hamid Dehnavi <[email protected]>
@shdehnavi @nickvergessen @fsamapoor
Make adjustments based on the review
92b75bc 
Co-authored-by: Joas Schilling <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
@fsamapoor fsamapoor force-pushed the refactor_comments_app branch from 7e4cead to 92b75bc Compare September 28, 2023 05:46
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2023
@skjnldsv skjnldsv merged commit 456aea8 into nextcloud:master Sep 28, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Sep 28, 2023

Cypress fails because fork master is not up to date, merging...

@fsamapoor
Copy link
Member

fsamapoor commented Sep 28, 2023 •
edited
Loading

Cypress fails because fork master is not up to date, merging...

Thank you for taking the time to explain why the Cypress workflows have been failing for the past weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@fsamapoor fsamapoor fsamapoor approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

5 participants

@shdehnavi @skjnldsv @fsamapoor @nickvergessen @solracsf