Skip to content

Conversation

@shdehnavi
Copy link
Contributor

Summary

The required adjustments have been made to the contactsinteraction app.

The improvements:

  • Adding return types
  • Adding types to properties
  • Adding throw types
  • Using PHP8's constructor property promotion

Checklist

@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@kesselb kesselb force-pushed the refactor_contactsinteraction_app branch from 84e3719 to c9b2007 Compare August 24, 2023 14:22
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🧹

@kesselb kesselb requested a review from miaulalala August 24, 2023 15:47
@kesselb kesselb force-pushed the refactor_contactsinteraction_app branch from c9b2007 to bab4955 Compare August 28, 2023 12:11
@kesselb kesselb force-pushed the refactor_contactsinteraction_app branch from bab4955 to e1b33e6 Compare August 29, 2023 09:35
@AndyScherzinger AndyScherzinger merged commit ad56458 into nextcloud:master Aug 29, 2023
@welcome
Copy link

welcome bot commented Aug 29, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants