Skip to content

Conversation

@provokateurin
Copy link
Member

Summary

From #36666. Adds the necessary annotations and descriptions.

Checklist

@provokateurin
Copy link
Member Author

@artonge @icewind1991 Can you help me with the CI failure? I don't see why my changes would cause any failure since they only add annotations which are completely ignored at runtime, thus no behavioral changes were made afaict

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of those tests are triggered only when some specific files are edited.
They might be failing for a long time 🙈 .
As your changes are mostly comments, I think we can merge without further concern.
If @icewind1991 agrees, feel free to merge :)

@provokateurin
Copy link
Member Author

Yeah I already imagined something like that. There is no way the comments can break something

@provokateurin provokateurin requested a review from bigcat88 July 12, 2023 20:15
@icewind1991 icewind1991 merged commit c3c58b6 into master Jul 13, 2023
@icewind1991 icewind1991 deleted the feature/openapi/files_external branch July 13, 2023 14:02
@icewind1991
Copy link
Member

S3 external test fix is here: #39367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants