Skip to content

[stable26] getStorage before remove #39355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Jul 13, 2023
Merged

[stable26] getStorage before remove #39355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
getStorage before remove 
Signed-off-by: Maxence Lange <[email protected]>
  • Loading branch information
@ArtificialOwl
ArtificialOwl committed Jul 13, 2023
commit bb189784f28e96c87093b9967e4c6b4eaa713369
6 changes: 6 additions & 0 deletions apps/files_external/lib/Service/UserStoragesService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,4 +143,10 @@ public function getVisibilityType() {
protected function isApplicable(StorageConfig $config) {
return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAl;
}

public function removeStorage($id) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\Files_External\Service\UserStoragesService::removeStorage does not have a return type, expecting void
// verify ownership through $this->isApplicable() and otherwise throws an exception
$this->getStorage($id);
parent::removeStorage($id);
}
}