Skip to content

Refactor user_ldap group membership cache and add check-group command #39446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 17 commits into from
Aug 10, 2023
Merged

Refactor user_ldap group membership cache and add check-group command #39446

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d8142b6
Refactor user_ldap group membership to use flat DB
come-nc Jul 20, 2023
d9b3680
Update autoloader mapping for user_ldap
come-nc Jul 20, 2023
34fa413
Add group events to UpdateGroups
come-nc Jul 20, 2023
2c19aac
Move UpdateGroups methods to a service
come-nc Jul 20, 2023
f9ed48e
Add check-group command
come-nc Jul 20, 2023
ec13f22
Add missing primary key for ldap_group_membership
come-nc Jul 20, 2023
1b102ca
Fix errors in UpdateGroupsService.php
come-nc Jul 20, 2023
ce5a4e5
Always empty cache before updating a group
come-nc Aug 1, 2023
7a14aa7
Add output to check-group --update command
come-nc Aug 1, 2023
42448c0
Fix getKnownGroups return value
come-nc Aug 3, 2023
1026b21
Fix check-group command for new groups
come-nc Aug 3, 2023
c33c40f
[user_ldap] Small perf improvements suggestion from review
come-nc Aug 7, 2023
ad1e487
Dispatch UserRemovedEvents for removed groups
come-nc Aug 7, 2023
7732de7
Removed GroupCreatedEvent/GroupDeletedEvent from UpdateGroupsService
come-nc Aug 7, 2023
5425f7d
Use BIGINT for new table id field
come-nc Aug 7, 2023
b8a0954
Fix check-group --update for deleted groups
come-nc Aug 7, 2023
a080811
Add unique index for user_ldap group memberships
come-nc Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add group events to UpdateGroups 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Aug 10, 2023
commit 34fa4138fb5c5f4e469d0b74b8773ce5d5f34609
7 changes: 7 additions & 0 deletions apps/user_ldap/lib/Jobs/UpdateGroups.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,10 @@ private function handleCreatedGroups(array $createdGroups): void {
foreach ($users as $user) {
$this->groupMembershipMapper->insert(GroupMembership::fromParams(['groupid' => $createdGroup,'userid' => $user]));
}
$groupObject = $this->groupManager->get($group);
if ($groupObject instanceof IGroup) {
$this->dispatcher->dispatchTyped(new GroupCreatedEvent($groupObject));
}
}
$this->logger->debug(
'bgJ "updateGroups" – FINISHED dealing with created Groups.',
Expand All @@ -207,6 +211,9 @@ private function handleRemovedGroups(array $removedGroups): void {
);

$this->groupMembershipMapper->deleteGroups($removedGroups);

//TODO find a way to dispatch GroupDeletedEvent

$this->logger->info(
'bgJ "updateGroups" – groups {removedGroups} were removed.',
[
Expand Down