Skip to content

Make .devcontainer independent of processor architecture #39464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsdicloud wants to merge 7 commits into from
Closed

Make .devcontainer independent of processor architecture #39464

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2923f85
Replace hardcoded arm64 by auto detected architecture
tsdicloud Jul 18, 2023
013c825
Clean network compose and NMC specific setup
tsdicloud Aug 19, 2023
7d1c3e5
Avoid corrupted config, prohibit overwrite of config on NC stop
tsdicloud Aug 21, 2023
aefda25
Check db health to avoid start witout db ready
tsdicloud Aug 25, 2023
7a6f7f1
addressing node and npm version compatibility issues
rhtot Jan 9, 2024
c983f5f
Revert "addressing node and npm version compatibility issues"
rhtot Jan 9, 2024
cd583c1
Merge branch 'master' into nmc/issues/39461-devcontainer-arm
memurats Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Replace hardcoded arm64 by auto detected architecture 
Signed-off-by: [email protected] <[email protected]>
  • Loading branch information
@tsdicloud
tsdicloud committed Aug 19, 2023
commit 2923f85d3dd5205ad8cc5c73eec5532ff3e3ee4d
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ RUN apt-get -y install \
software-properties-common && \
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | apt-key add - && \
add-apt-repository \
"deb [arch=amd64] https://download.docker.com/linux/ubuntu \
"deb [arch=$(dpkg --print-architecture)] https://download.docker.com/linux/ubuntu \
$(lsb_release -cs) \
stable" && \
apt-get update -y && \
Expand Down