Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 19, 2023

Summary

Update symfony http-foundation, routing and translation to 5.4.24.

TODO

Checklist

@kesselb kesselb self-assigned this Jul 19, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Jul 19, 2023
@kesselb
Copy link
Contributor Author

kesselb commented Jul 19, 2023

UPGRADE FROM 4.4 to 5.0

Routing

  • The generator_base_class, generator_cache_class, matcher_base_class, and matcher_cache_class router
    options have been removed. If you are using multiple Router instances and need separate caches for them, set a unique cache_dir per Router instance instead.
  • Serializable implementing methods for Route and CompiledRoute are final.
    Instead of overwriting them, use __serialize and __unserialize as extension points which are forward compatible
    with the new serialization methods in PHP 7.4.
  • Removed ServiceRouterLoader and ObjectRouteLoader.
  • Service route loaders must be tagged with routing.route_loader.
  • The RoutingConfigurator::import() method has a new optional $exclude argument.

Translation

  • Support for using null as the locale in Translator has been removed.
  • The FileDumper::setBackup() method has been removed.
  • The TranslationWriter::disableBackup() method has been removed.
  • The TranslatorInterface has been removed in favor of Symfony\Contracts\Translation\TranslatorInterface
  • The MessageSelector, Interval and PluralizationRules classes have been removed, use IdentityTranslator instead
  • The Translator::getFallbackLocales() and TranslationDataCollector::getFallbackLocales() method are now internal
  • The Translator::transChoice() method has been removed in favor of using Translator::trans() with "%count%" as the parameter driving plurals
  • Removed support for implicit STDIN usage in the lint:xliff command, use lint:xliff - (append a dash) instead to make it explicit.

UPGRADE FROM 5.0 to 5.1

Routing

  • Deprecated RouteCollectionBuilder in favor of RoutingConfigurator.
  • Added argument $priority to RouteCollection::add()
  • Deprecated the RouteCompiler::REGEX_DELIMITER constant

UPGRADE FROM 5.1 to 5.2

🎉

UPGRADE FROM 5.2 to 5.3

Routing

  • Deprecate creating instances of the Route annotation class by passing an array of parameters, use named arguments instead

UPGRADE FROM 5.3 to 5.4

Translation

  • The following data providers for ProviderFactoryTestCase are now static: supportsProvider(), createProvider(), unsupportedSchemeProvider()and incompleteDsnProvider()
  • ProviderTestCase::toStringProvider() is now static

@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 19, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to see how you went through the upgrade instructions 😊

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are happy, so am I

@kesselb kesselb force-pushed the 3rdparty-bump-symfony-http-routing-translation branch from b72430f to cc2fae5 Compare July 19, 2023 21:20
@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 19, 2023
@kesselb kesselb merged commit b168325 into master Jul 19, 2023
@kesselb kesselb deleted the 3rdparty-bump-symfony-http-routing-translation branch July 19, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish dependencies

Projects

Development

Successfully merging this pull request may close these issues.

4 participants