Bug fix: Select the correct table based on CALENDAR_TYPE_CALENDAR #39553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero0cool0
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
tcitworld
approved these changes
Jul 24, 2023
| */ | ||
| public function getChangesForCalendar($calendarId, $syncToken, $syncLevel, $limit = null, $calendarType = self::CALENDAR_TYPE_CALENDAR) { | ||
| return $this->atomic(function () use ($calendarId, $syncToken, $syncLevel, $limit, $calendarType) { | ||
| $table = $calendarType === self::CALENDAR_TYPE_CALENDAR ? 'calendars': 'calendarsubscriptions'; |
Member
There was a problem hiding this comment.
suggestion: You can put this line directly into the callback function.
tcitworld
added
bug
3. to review
ChristophWurst
approved these changes
Jul 24, 2023
Member
|
@zero0cool0 Please sign (DCO) your commit. The tests are failing on that. Click the red DCO fail link for details. |
ChristophWurst
added
4. to release
Member
|
/backport to stable27 |
Member
|
/backport to stable26 |
Merged
Signed-off-by: Patrick Fischer <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
/backport to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getChangesForCalendaralways selects thecalendarstable but should select eithercalendarsorcalendarsubscriptionsbased on function argumentcalendarType.