Skip to content

Catch more invalid cache source storage paths #39698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Aug 5, 2023
Merged

Catch more invalid cache source storage paths #39698

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deecb48
Catch more invalid cache source storage paths
joshtrichards Aug 3, 2023
7b7d1e3
fix: simplify `sourceData` check
skjnldsv Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/Files/Cache/Cache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ public function moveFromCache(ICache $sourceCache, $sourcePath, $targetPath) {
$targetPath = $this->normalize($targetPath);

$sourceData = $sourceCache->get($sourcePath);
if ($sourceData === false) {
if ($sourceData === false || $sourceData === null) {
throw new \Exception('Invalid source storage path: ' . $sourcePath);
}

Expand Down