Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 3, 2023

Summary

🚀

TODO

  • Ci
  • Review

Checklist

@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Aug 3, 2023
@kesselb kesselb self-assigned this Aug 3, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd even say this is a bugfix. Let's backport

@kesselb kesselb force-pushed the debt/noid/invitation-response-close-cursor branch from 0167e90 to a4fe5ee Compare August 3, 2023 20:02
@kesselb
Copy link
Contributor Author

kesselb commented Aug 3, 2023

/backport to stable26

@kesselb
Copy link
Contributor Author

kesselb commented Aug 3, 2023

/backport to stable25

@kesselb
Copy link
Contributor Author

kesselb commented Aug 3, 2023

/backport to stable27

@kesselb kesselb added this to the Nextcloud 28 milestone Aug 3, 2023
@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 3, 2023
@tcitworld
Copy link
Member

CI failures look suspicious

@kesselb kesselb force-pushed the debt/noid/invitation-response-close-cursor branch from a4fe5ee to 6389c87 Compare August 4, 2023 15:36
@kesselb
Copy link
Contributor Author

kesselb commented Aug 4, 2023

CI failures look suspicious

Thanks, updated the tests to expect executeQuery.

@kesselb kesselb force-pushed the debt/noid/invitation-response-close-cursor branch from 6389c87 to 176a2a0 Compare August 10, 2023 13:02
@ChristophWurst
Copy link
Member

failing acceptance tests should be unrelated

@kesselb kesselb force-pushed the debt/noid/invitation-response-close-cursor branch from 176a2a0 to 378a0f9 Compare August 10, 2023 19:46
@nickvergessen nickvergessen merged commit 03f5bb6 into master Aug 11, 2023
@nickvergessen nickvergessen deleted the debt/noid/invitation-response-close-cursor branch August 11, 2023 16:00
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@kesselb
Copy link
Contributor Author

kesselb commented Dec 1, 2023

backports for 27 and 26 are in.

impact is low and 25 eol and therefore no backport for 25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants