Skip to content

[stable25] Catch more invalid cache source storage paths #39731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 2 commits into from
Sep 5, 2023
Merged

[stable25] Catch more invalid cache source storage paths #39731

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc801d7
Catch more invalid cache source storage paths
joshtrichards Aug 3, 2023
3330403
fix: simplify `sourceData` check
skjnldsv Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: simplify sourceData check 
Co-authored-by: Git'Fellow <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
  • Loading branch information
@skjnldsv @solracsf @backportbot-nextcloud
2 people authored and backportbot-nextcloud[bot] committed Aug 6, 2023
commit 333040303102b94c608fb29a51f74204cd08f9f9
2 changes: 1 addition & 1 deletion lib/private/Files/Cache/Cache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ public function moveFromCache(ICache $sourceCache, $sourcePath, $targetPath) {
$targetPath = $this->normalize($targetPath);

$sourceData = $sourceCache->get($sourcePath);
if ($sourceData === false || $sourceData === null) {
if (!$sourceData) {
throw new \Exception('Invalid source storage path: ' . $sourcePath);
}

Expand Down