Skip to content

[stable27] The almighty text processing PR #39776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcelklehr merged 111 commits into from
Aug 9, 2023
Merged

[stable27] The almighty text processing PR #39776

marcelklehr merged 111 commits into from
Aug 9, 2023

Conversation

@marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Aug 9, 2023 •
edited
Loading

Contains backports of

Checklist

marcelklehr and others added 30 commits August 9, 2023 09:55
@marcelklehr
Initial work on lm OCP API
2e9dea2 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 70d5bf7)
@marcelklehr
LLM OCP API: Rework to use Task objects
457f1eb 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 01dd1a8)
@marcelklehr
LLM OCP API: Implement private backend code + add ILanguageModelTask
d20ee42 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 3413873)
@marcelklehr
LLM OCP API: Add db migration
7031072 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 6fc4cb6)
@marcelklehr
LLM OCP API: Add to RegistrationContext
ed3672a 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 82d3b00)
@marcelklehr
Fix Copyright
33f3379 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 9e9fc1d)
@marcelklehr
LLM OCP API: ADd topics and headline tasks
5807c43 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 9d5717d)
@marcelklehr
LLM OCP API: Implement ocs API
236c32b 
Signed-off-by: Marcel Klehr <[email protected]>

(cherry picked from commit 795b097)
@marcelklehr
LLM OCP API: cs:fix
76a5db8 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit b6941aa)
@marcelklehr
LLM OCP API: Make linters happy
01db2cf 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit b8a9f08)
@marcelklehr
LLM OCP API: Fix type errors
dbd9420 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit b6a95e3)
@marcelklehr
LLM OCP API: Add @SInCE
0024f0d 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 9935034)
@marcelklehr
LLM OCP API: Fix static analysis
02c78be 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit fac83ce)
@marcelklehr
LLM OCP API: cs:fix
612af73 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 75d7af8)
@marcelklehr
LLM OCP API: Fix coding style and psalm
dd7eafa 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 72ea761)
@marcelklehr @julien-nc
Update lib/public/LanguageModel/ITopicsProvider.php
6320c68 
Co-authored-by: Julien Veyssier <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 249dd5c)
@marcelklehr
LLM OCP API: Add task definitions
ecda18b 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit fb4de16)
@marcelklehr
LLM OCP API: Commit autoloaders
1ac86d2 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 5bc6180)
@marcelklehr @kesselb
Update lib/public/AppFramework/Bootstrap/IRegistrationContext.php
4e3ca11 
Co-authored-by: Daniel <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit fb55afc)
@marcelklehr @kesselb
Apply suggestions from code review
4405027 
Co-authored-by: Daniel <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 8e4aa92)
@marcelklehr
LLM OCP API: Type shenanigans for Visitor pattern
c8bbe8f 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 906e9b7)
@marcelklehr
LLM OCP API: strict types and copyright
ddeaaea 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 83db23e)
@marcelklehr
OCP: Introduce OCP\Common\Exception\NotFoundException
d203e3a 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit a7cd6bf)
@marcelklehr
LLM OCP API: Use OCP\Common\Exception\NotFoundException
fb9262e 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit b00a9a6)
@marcelklehr
LLM OCP API: Fix copyright
e90dd4a 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 94fcf88)
@marcelklehr
cs:fix
44ce285 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 1d3661d)
@marcelklehr
Add tasks::last_updated column and vacate tasks after a week
91325ef 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit cb0f918)
@marcelklehr
TaskMapper#update: Use time factory
2234497 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 1623ad9)
@marcelklehr
ILanguageModelManager: Add docblock description
970d688 
Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 0a94525)
@marcelklehr
ILanguageModelTask: Use php type checking along with psalm parameteri…
c1085bf 
…zed types

Signed-off-by: Marcel Klehr <[email protected]>
(cherry picked from commit 27e1c86)
@julien-nc julien-nc force-pushed the backport/39680/stable27 branch 3 times, most recently from c4c3fe7 to 19fbce6 Compare August 9, 2023 10:00
julien-nc
julien-nc approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@julien-nc
Copy link
Member

julien-nc commented Aug 9, 2023 •
edited
Loading

Psalm issue because missing core/ResponseDefinitions.php. Even if we add this file, the OCA\Core namespace is not valid in stable27.
@provokateurin Any clue?

@provokateurin
Copy link
Member

provokateurin commented Aug 9, 2023

The annotations are not available in stable27. The are only on master

@marcelklehr
Copy link
Member Author

marcelklehr commented Aug 9, 2023

The annotations are not available in stable27.

Ah, right. then we need to remove them

@julien-nc julien-nc force-pushed the backport/39680/stable27 branch from 19fbce6 to 46aebe8 Compare August 9, 2023 11:08
@marcelklehr marcelklehr added this to the Nextcloud 27.1.0 milestone Aug 9, 2023
@marcelklehr
Copy link
Member Author

marcelklehr commented Aug 9, 2023

🎉

@juliusknorr juliusknorr added enhancement 3. to review Waiting for reviews labels Aug 9, 2023
juliusknorr
juliusknorr reviewed Aug 9, 2023
View reviewed changes
juliusknorr
juliusknorr approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, just left a comment on the version bump to clarify before merge

julien-nc and others added 9 commits August 9, 2023 14:58
@julien-nc
start implementing ocs endpoint to get task list from user+appId+iden…
6eb1857 
…tifier

Signed-off-by: Julien Veyssier <[email protected]>
(cherry picked from commit 9986e02)
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
allow anon text processing scheduling
8e657a8 
add a textprocessing_tasks index
convert anotations to method attributes
refactor TP manager
add mapper methods

Signed-off-by: Julien Veyssier <[email protected]>

(cherry picked from commit 41b19cf)
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
change sql where order to match index order
f363f11 
Signed-off-by: Julien Veyssier <[email protected]>
(cherry picked from commit 05a6a79)
Signed-off-by: Julien Veyssier <[email protected]>
@juliusknorr @julien-nc
feat: Add delete task API
0564bd2 
Signed-off-by: Julius Härtl <[email protected]>
(cherry picked from commit fca1c30)
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix psalm issue
993a559 
Signed-off-by: Julien Veyssier <[email protected]>
(cherry picked from commit f154fe7)
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix eslint issue
79d43fa 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix psalm issues
8a9ad05 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
bump last version digit
240eb88 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
compile assets
71db3ff 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc force-pushed the backport/39680/stable27 branch from 46aebe8 to 71db3ff Compare August 9, 2023 12:59
@julien-nc
Copy link
Member

julien-nc commented Aug 9, 2023

Removed the 2 commits changing version.php, added one bumping the last version digit. Put the "compile assets" commit on top.

@marcelklehr marcelklehr enabled auto-merge August 9, 2023 13:11
@marcelklehr marcelklehr merged commit b2589c8 into stable27 Aug 9, 2023
@marcelklehr marcelklehr deleted the backport/39680/stable27 branch August 9, 2023 13:47
@skjnldsv skjnldsv mentioned this pull request Aug 16, 2023
Merged
7 tasks
@susnux susnux mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

@julien-nc julien-nc julien-nc approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter JuliaKirschenheuter is a code owner

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 27.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

@marcelklehr @julien-nc @provokateurin @juliusknorr @skjnldsv @kesselb