[stable25] optimize calendar search query

[backportbot-nextcloud]

Backport of #39741

[AndyScherzinger]

@ChristophWurst are the CI failures relevant?

[ChristophWurst]

https://drone.nextcloud.com/nextcloud/server/38388/15/5 looks related, yes

[ChristophWurst]

1) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSearchPrincipal
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 END:VTIMEZONE\n
 BEGIN:VEVENT\n
 DTSTART;TZID=Europe/Berlin:20160419T130000\n
-SUMMARY:My Test (public)\n
-CLASS:PUBLIC\n
+SUMMARY:My Test (confidential)\n
+CLASS:CONFIDENTIAL\n
 TRANSP:OPAQUE\n
 STATUS:CONFIRMED\n
 DTEND;TZID=Europe/Berlin:20160419T140000\n
@@ @@
 LAST-MODIFIED:20160419T074202Z\n
 DTSTAMP:20160419T074202Z\n
 CREATED:20160419T074202Z\n
-UID:2e468c48-7860-492e-bc52-92fa0daeeccf.1461051722310-1\n
+UID:2e468c48-7860-492e-bc52-92fa0daeeccf.1461051722310-3\n
 END:VEVENT\n
 END:VCALENDAR'

/drone/src/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php:1277

[ChristophWurst]

Interesting enough the test succeded on master and stable26

[tcitworld]

Looks like the returned order changed, however since there's no orderBy happening in these requests it could just be a race condition having made the insertion in the wrong order, which is likely since the test only failed on pg10php7.4.

Do you mind retrying it to check if it's indeed flaky?

[ChristophWurst]

@AndyScherzinger could you please restart the drone run https://drone.nextcloud.com/nextcloud/server/38388? I lack permissions

[AndyScherzinger]

@AndyScherzinger could you please restart the drone run https://drone.nextcloud.com/nextcloud/server/38388? I lack permissions

DONE @ChristophWurst

[tcitworld]

Job passed this time 🤷

[ChristophWurst]

So nothing is broken, yay. But it means that the test might be a bit flaky and fail occasionally in the future.

[AndyScherzinger]

Merged in alignment with Christoph, there might be a follow-up PR for stabilizing the flaky test.