Add a separate event for login page rendering #39867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
login-less
branch
3 times, most recently
from
1facc8c to
40cf409
Compare
Member
Author
|
https://github.com/nextcloud/unsplash/blob/4c04d275e9e2469c5b6f1b3d2b6f24cfe9db9887/lib/EventListener/BeforeTemplateRenderedEventListener.php#L18 is the only non-core app I could find in a quick search that would need to be adjusted |
nickvergessen
approved these changes
Aug 16, 2023
Member
Author
Seems safe to me to apply this change. |
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
login-less
branch
from
ca5e283 to
1df3325
Compare
Closed
4 tasks
icewind1991
added
3. to review
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
nfebe
and removed request for
a team
icewind1991
added
the
pending documentation
AndyScherzinger
approved these changes
Aug 18, 2023
Member
|
breaks the installer styling and scripts. |
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
The new event is not emitted
Member
Author
|
The downside of having your dev setup perform the setup automatically 🙈 |
Member
Author
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only very few apps actually need to add their scripts/styles to the login page, but it's currently easy for apps to accidentally do that anyway.
By having a separate event, having your scripts on the login page becomes opt-in rather than opt-out.